Bug 67814

Summary: [Qt] Remove common.pri
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cshu, kenneth, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
kling: review+, kling: commit-queue-
for cq. This time used svn to create the patch none

Laszlo Gombos
Reported 2011-09-08 16:03:28 PDT
It seems to me that common.pri does not have a defined "identity". The content of common.pri could be just moved to WebKit.pri as WebKit.pri gets already included for the relevant .pro files where common.pri is included. In addition common.pri is not quite "common" as it is not included for every WebKit pro file (as an example WebProcess.pro does not include common.pri). I propose to remove common.pri. Alternatively we can define a purpose for common.pri and use it consistently.
Attachments
Proposed patch (4.04 KB, patch)
2011-09-08 16:10 PDT, Laszlo Gombos 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
for cq. This time used svn to create the patch (4.88 KB, patch)
2011-09-09 10:11 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-09-08 16:10:57 PDT
Created attachment 106808 [details] Proposed patch
Andreas Kling
Comment 2 2011-09-09 04:06:06 PDT
Comment on attachment 106808 [details] Proposed patch r=me. The patch is missing the hunk to kill common.pri though, so cq-.
Laszlo Gombos
Comment 3 2011-09-09 10:11:33 PDT
Created attachment 106883 [details] for cq. This time used svn to create the patch
WebKit Review Bot
Comment 4 2011-09-09 11:10:08 PDT
Comment on attachment 106883 [details] for cq. This time used svn to create the patch Clearing flags on attachment: 106883 Committed r94866: <http://trac.webkit.org/changeset/94866>
WebKit Review Bot
Comment 5 2011-09-09 11:10:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.