Summary: | Web Inspector: extract RawSourceCode source mapping logic to helper classes. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Podivilov
2011-09-08 10:52:21 PDT
Created attachment 106762 [details]
Patch
Comment on attachment 106762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > Source/WebCore/inspector/front-end/SourceFile.js:225 > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy. (In reply to comment #2) > (From update of attachment 106762 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > > > Source/WebCore/inspector/front-end/SourceFile.js:225 > > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) > > Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy. This is not a new code. It's a part of existing RawSourceCode implementation that was moved to a separate class to remove duplicated state checks (e.g. "if formatted" and "if source map installed"). (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 106762 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > > > > > Source/WebCore/inspector/front-end/SourceFile.js:225 > > > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) > > > > Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy. Also, source mapping is a part of RawSourceCode interface, a link to UISourceCode and ui locations. Committed r95522: <http://trac.webkit.org/changeset/95522> |