RESOLVED FIXED 67789
Web Inspector: extract RawSourceCode source mapping logic to helper classes. 
https://bugs.webkit.org/show_bug.cgi?id=67789
Summary Web Inspector: extract RawSourceCode source mapping logic to helper classes.
Pavel Podivilov
Reported 2011-09-08 10:52:21 PDT
Web Inspector: extract RawSourceCode source mapping logic to helper classes.
Attachments
Patch (7.71 KB, patch)
2011-09-08 10:54 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-09-08 10:54:15 PDT
Created attachment 106762 [details] Patch
Pavel Feldman
Comment 2 2011-09-19 00:40:09 PDT
Comment on attachment 106762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > Source/WebCore/inspector/front-end/SourceFile.js:225 > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy.
Pavel Podivilov
Comment 3 2011-09-19 03:40:46 PDT
(In reply to comment #2) > (From update of attachment 106762 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > > > Source/WebCore/inspector/front-end/SourceFile.js:225 > > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) > > Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy. This is not a new code. It's a part of existing RawSourceCode implementation that was moved to a separate class to remove duplicated state checks (e.g. "if formatted" and "if source map installed").
Pavel Podivilov
Comment 4 2011-09-19 03:53:20 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 106762 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=106762&action=review > > > > > Source/WebCore/inspector/front-end/SourceFile.js:225 > > > +WebInspector.RawSourceCode.FormattedSourceMapping = function(rawSourceCode, uiSourceCode, mapping) > > > > Why does formatted source mapping live under the raw source code? I was expecting formatting to be a part of the UI* hierarchy. Also, source mapping is a part of RawSourceCode interface, a link to UISourceCode and ui locations.
Pavel Podivilov
Comment 5 2011-09-20 02:28:09 PDT
Committed r95522: <http://trac.webkit.org/changeset/95522>
Note You need to log in before you can comment on or make changes to this bug.