Bug 67765 – Crashed in WebCore::ApplyStyleCommand.doApply()

• Component: HTML Editing
• Status: RESOLVED FIXED

[Shinya Kawanaka]

<card id="edit" contentEditable="true">A<script>
edit.focus();
document.execCommand("SelectAll");
document.execCommand("RemoveFormat");
</script>

[Shinya Kawanaka]

Created attachment 106708 [details]
Patch

[Shinya Kawanaka]

*** Bug 67766 has been marked as a duplicate of this bug. ***

[Darin Adler]

Comment on attachment 106708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106708&action=review

> LayoutTests/editing/style/remove-format-without-enclosing-block.html:9
> +document.writeln('<br><br>This test ensures WebKit does not crash.<br><br>PASS');

The wording here is wrong. The test does not ensure that WebKit does not crash. The test has no effect on WebKit.

It's good to say that the test has passed if it doesn’t crash, and also probably good to say as clearly as possible why there was a time when the test would crash.

[Shinya Kawanaka]

Created attachment 106848 [details]
Patch

[Shinya Kawanaka]

(In reply to comment #3)
> (From update of attachment 106708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106708&action=review
> 
> > LayoutTests/editing/style/remove-format-without-enclosing-block.html:9
> > +document.writeln('<br><br>This test ensures WebKit does not crash.<br><br>PASS');
> 
> The wording here is wrong. The test does not ensure that WebKit does not crash. The test has no effect on WebKit.

Fixed.

> 
> It's good to say that the test has passed if it doesn’t crash, and also probably good to say as clearly as possible why there was a time when the test would crash.

I added some comments in a test case.

[WebKit Review Bot]

Comment on attachment 106848 [details]
Patch

Clearing flags on attachment: 106848

Committed r94840: <http://trac.webkit.org/changeset/94840>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.