Bug 67751

Summary: Rebaseline for bug 65583 (path based border radius drawing on skia) part 2
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mikelawther, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
LayoutTests/platform/chromium-linux/fast/forms/basic-selects-expected.png
none
LayoutTests/platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png
none
LayoutTests/platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png
none
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png
none
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png
none
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png
none
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png
none
LayoutTests/platform/chromium-linux/fast/transforms/shadows-expected.png
none
LayoutTests/platform/chromium-win/fast/forms/basic-selects-expected.png
none
LayoutTests/platform/chromium-win/fast/repaint/border-radius-repaint-expected.png none

Description Ben Wells 2011-09-07 18:20:27 PDT
Rebaseline for bug 65583 (path based border radius drawing on skia) part 2
Comment 1 Ben Wells 2011-09-07 18:54:47 PDT
Created attachment 106680 [details]
Patch
Comment 2 Ben Wells 2011-09-07 18:58:10 PDT
Due to bug 67628, some images can't be seen in the formatted diff. I am attaching all the new images separately.
Comment 3 Ben Wells 2011-09-07 18:59:25 PDT
Created attachment 106682 [details]
LayoutTests/platform/chromium-linux/fast/forms/basic-selects-expected.png
Comment 4 Ben Wells 2011-09-07 19:00:19 PDT
Created attachment 106683 [details]
LayoutTests/platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png
Comment 5 Ben Wells 2011-09-07 19:00:47 PDT
Created attachment 106684 [details]
LayoutTests/platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png
Comment 6 Ben Wells 2011-09-07 19:01:27 PDT
Created attachment 106685 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png
Comment 7 WebKit Review Bot 2011-09-07 19:01:36 PDT
Attachment 106680 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

ERROR: FAILURES FOR <lucid, x86_64, release, cpu>
ERROR: Line:3430 Path does not exist. compositing/color-matching/image-makering.html
LayoutTests/platform/chromium/test_expectations.txt:3430:  Path does not exist. compositing/color-matching/image-makering.html  [test/expectations] [2]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Ben Wells 2011-09-07 19:02:21 PDT
Created attachment 106686 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png
Comment 9 Ben Wells 2011-09-07 19:03:00 PDT
Created attachment 106687 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png
Comment 10 Ben Wells 2011-09-07 19:04:17 PDT
Created attachment 106688 [details]
LayoutTests/platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png
Comment 11 Ben Wells 2011-09-07 19:04:43 PDT
Created attachment 106689 [details]
LayoutTests/platform/chromium-linux/fast/transforms/shadows-expected.png
Comment 12 Ben Wells 2011-09-07 19:05:16 PDT
Created attachment 106690 [details]
LayoutTests/platform/chromium-win/fast/forms/basic-selects-expected.png
Comment 13 Ben Wells 2011-09-07 19:05:50 PDT
Created attachment 106691 [details]
LayoutTests/platform/chromium-win/fast/repaint/border-radius-repaint-expected.png
Comment 14 Ben Wells 2011-09-07 19:06:14 PDT
Style error is in a part of the file I haven't changed.
Comment 15 Kenneth Russell 2011-09-07 20:40:58 PDT
Comment on attachment 106680 [details]
Patch

Where the before-and-after images show up in the pretty diff, the new baselines look good. It was a little difficult to reason about the separately attached ones. Please press ahead with https://bugs.webkit.org/show_bug.cgi?id=67628 . Thanks. r=me
Comment 16 WebKit Review Bot 2011-09-08 12:44:21 PDT
Comment on attachment 106680 [details]
Patch

Clearing flags on attachment: 106680

Committed r94782: <http://trac.webkit.org/changeset/94782>
Comment 17 WebKit Review Bot 2011-09-08 12:44:28 PDT
All reviewed patches have been landed.  Closing bug.