Bug 67749

Summary:

AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter

Product:

WebKit

Reporter:

Chris Rogers <crogers>

Component:

New Bugs

Assignee:

Chris Rogers <crogers>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kbr

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kbr: review+

Description Chris Rogers 2011-09-07 17:28:40 PDT

AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter

Comment 1 Chris Rogers 2011-09-07 18:32:26 PDT

Created attachment 106677 [details]
Patch

Comment 2 Kenneth Russell 2011-09-07 20:30:56 PDT

Comment on attachment 106677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106677&action=review

Looks fine; one minor comment.

> Source/WebCore/webaudio/AudioBufferSourceNode.cpp:341
> +            return false; // the current implementation handles only mono and stereo playback

Do you want to add a FIXME here?

Comment 3 Chris Rogers 2011-09-09 15:14:39 PDT

Committed r94878: <http://trac.webkit.org/changeset/94878>