Bug 67749

Summary: AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Chris Rogers
Reported 2011-09-07 17:28:40 PDT
AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
Attachments
Patch (12.52 KB, patch)
2011-09-07 18:32 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-09-07 18:32:26 PDT
Created attachment 106677 [details] Patch
Kenneth Russell
Comment 2 2011-09-07 20:30:56 PDT
Comment on attachment 106677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106677&action=review Looks fine; one minor comment. > Source/WebCore/webaudio/AudioBufferSourceNode.cpp:341 > + return false; // the current implementation handles only mono and stereo playback Do you want to add a FIXME here?
Chris Rogers
Comment 3 2011-09-09 15:14:39 PDT
Committed r94878: <http://trac.webkit.org/changeset/94878>
Note You need to log in before you can comment on or make changes to this bug.