Bug 67740 – Fixed Hit testing on Framesets when Frameset is transformed

• Component: New Bugs
• Status: RESOLVED FIXED

[Fady Samuel]

Fixed Hit testing on Framesets when Frameset is transformed

[Fady Samuel]

Created attachment 106657 [details]
Patch

[Fady Samuel]

I'm not sure how to write a layout test for this. I'll gladly welcome suggestions if possible...

[Simon Fraser (smfr)]

Comment on attachment 106657 [details]
Patch

Should be able to test with document.elementFromPoint().

[Fady Samuel]

Created attachment 109215 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 109215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109215&action=review

Code changes look ok, but r- for one more test.

> LayoutTests/fast/frames/frame-set-scaling-hit.html:15
> +        function init() {
> +            if (!window.eventSender)
> +                return;
> +            var leftPanelWidth = window.innerWidth / 8;
> +            eventSender.scalePageBy(0.5, 0, 0);
> +            eventSender.mouseMoveTo(leftPanelWidth, window.innerHeight / 4);
> +            eventSender.mouseDown();
> +            eventSender.mouseMoveTo(2 * leftPanelWidth, window.innerHeight / 4);
> +            eventSender.mouseUp();
> +        }

Please add a comment to say that this is trying to resize the frames. It wasn't obvious.

I'd like to see a test that has a rotation too.

[Fady Samuel]

Created attachment 109246 [details]
Patch

[WebKit Review Bot]

Comment on attachment 109246 [details]
Patch

Clearing flags on attachment: 109246

Committed r96385: <http://trac.webkit.org/changeset/96385>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.