Summary: | Fixed Hit testing on Framesets when Frameset is transformed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fady Samuel <fsamuel> | ||||||||
Component: | New Bugs | Assignee: | Fady Samuel <fsamuel> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | fsamuel, rjkroege, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fady Samuel
2011-09-07 15:23:55 PDT
Created attachment 106657 [details]
Patch
I'm not sure how to write a layout test for this. I'll gladly welcome suggestions if possible... Comment on attachment 106657 [details]
Patch
Should be able to test with document.elementFromPoint().
Created attachment 109215 [details]
Patch
Comment on attachment 109215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109215&action=review Code changes look ok, but r- for one more test. > LayoutTests/fast/frames/frame-set-scaling-hit.html:15 > + function init() { > + if (!window.eventSender) > + return; > + var leftPanelWidth = window.innerWidth / 8; > + eventSender.scalePageBy(0.5, 0, 0); > + eventSender.mouseMoveTo(leftPanelWidth, window.innerHeight / 4); > + eventSender.mouseDown(); > + eventSender.mouseMoveTo(2 * leftPanelWidth, window.innerHeight / 4); > + eventSender.mouseUp(); > + } Please add a comment to say that this is trying to resize the frames. It wasn't obvious. I'd like to see a test that has a rotation too. Created attachment 109246 [details]
Patch
Comment on attachment 109246 [details] Patch Clearing flags on attachment: 109246 Committed r96385: <http://trac.webkit.org/changeset/96385> All reviewed patches have been landed. Closing bug. |