Bug 67739 – adjustRectForColumns is slow when a huge # of columns are involved

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

adjustRectForColumns is slow when a huge # of columns are involved, since it always loops over every single column regardless of how tiny the repaint rect is. This is a stupid thing to do, since intermediate columns between your beginning and end column always fully repaint anyway.

[Dave Hyatt]

Created attachment 106659 [details]
Patch

[WebKit Review Bot]

Attachment 106659 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderBlock.cpp:4622:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 106659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106659&action=review

>> Source/WebCore/rendering/RenderBlock.cpp:4622
>> +    if (colHeight == 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

That’s right.

[Dave Hyatt]

Fixed in r94737.

[Ryosuke Niwa]

This patch broke Windows build:
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20697/steps/compile-webkit/logs/stdio

[Ryosuke Niwa]

Fixed Windows build in http://trac.webkit.org/changeset/94739 and http://trac.webkit.org/changeset/94740.