Bug 67730

Summary: Support the hyphenate-limit-lines property
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, rniwa, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67768    
Attachments:
Description Flags
Avoid runs of consecutive hyphenated lines longer than the limit hyatt: review+

Attachments
Avoid runs of consecutive hyphenated lines longer than the limit (143.41 KB, patch)
2011-09-07 13:44 PDT, mitz 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2011-09-07 13:44:46 PDT
Created attachment 106629 [details] Avoid runs of consecutive hyphenated lines longer than the limit This first cut simply prevents hyphenation of a line if the limit has been reached. This can be refined to restrict hyphenation even before reaching the limit.
Dave Hyatt
Comment 2 2011-09-07 13:53:43 PDT
Comment on attachment 106629 [details] Avoid runs of consecutive hyphenated lines longer than the limit r=me
mitz
Comment 3 2011-09-07 13:59:16 PDT
Landed in <http://trac.webkit.org/r94710>.
Ryosuke Niwa
Comment 4 2011-09-07 16:26:20 PDT
Rebaseline: http://trac.webkit.org/changeset/94726.
mitz
Comment 5 2011-09-07 16:37:13 PDT
Thank you!
Ryosuke Niwa
Comment 6 2011-09-07 19:12:46 PDT
The test added by this patch is failing on Snow Leopard. http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r94737%20(32908)/fast/text/hyphenate-limit-lines-pretty-diff.html Should we just rebaseline or not?
mitz
Comment 7 2011-09-07 19:20:19 PDT
Those results look wrong.
Ryosuke Niwa
Comment 8 2011-09-07 19:22:51 PDT
(In reply to comment #7) > Those results look wrong. Can we file a bug and skip it temporarily on the bot?
mitz
Comment 9 2011-09-07 20:35:10 PDT
Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation. I am going to commit the current results as expected for Snow Leopard and earlier.
mitz
Comment 10 2011-09-07 20:39:21 PDT
Snow Leopard results added in <http://trac.webkit.org/r94743>.
Simon Fraser (smfr)
Comment 11 2011-09-08 09:04:49 PDT
(In reply to comment #9) > Unfortunately, hyphenation on Snow Leopard gets confused by trailing punctuation. Should a new bug be filed to cover this?
Note You need to log in before you can comment on or make changes to this bug.