Bug 67724

Summary: Chromium shadow-buffer-partial test change.
Product: WebKit Reporter: bungeman
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

bungeman
Reported 2011-09-07 11:55:18 PDT
A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/shadow-buffer-partial needs to be updated, as it currently has an incorrect blur. This change will be to update the expected png and set the test to be skipped. Once chromium rolls to skip the test, the fix there (currently disabled) will be enabled. Then, after webkit rolls chromium past this change, there will be another webkit change to re-enable the test.
Attachments
Patch (10.67 KB, patch)
2011-09-07 12:07 PDT, bungeman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
bungeman
Comment 1 2011-09-07 12:07:22 PDT
Created attachment 106619 [details] Patch
bungeman
Comment 2 2011-09-08 06:05:13 PDT
Adding reviewer.
Kenneth Russell
Comment 3 2011-09-08 13:46:00 PDT
Comment on attachment 106619 [details] Patch Seems fine.
WebKit Review Bot
Comment 4 2011-09-08 14:15:36 PDT
Comment on attachment 106619 [details] Patch Clearing flags on attachment: 106619 Committed r94798: <http://trac.webkit.org/changeset/94798>
WebKit Review Bot
Comment 5 2011-09-08 14:15:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.