| Summary: | Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, mamacdon, pfeldman, pmuellr, rik, timothy, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexander Pavlov (apavlov)
2011-09-07 08:44:41 PDT
Created attachment 106590 [details]
[PATCH] Suggested fix
Comment on attachment 106590 [details] [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:495 > this._shortcuts[shortcutK.key].isMacOnly = true; I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler. (In reply to comment #3) > (From update of attachment 106590 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review > > > Source/WebCore/inspector/front-end/ConsoleView.js:495 > > this._shortcuts[shortcutK.key].isMacOnly = true; > > I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler. Does it make sense to have the isMacOnly flag at all? Can't believe it's the only instance of its usage... Created attachment 106712 [details]
[PATCH] Comments addressed
Committed r94758: <http://trac.webkit.org/changeset/94758> |