Bug 67691

Summary: Remove getUInt32 from JSCell
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Mark Hahnenberg 2011-09-06 18:29:52 PDT 
getUInt32 is no longer used in JSC.  We should remove it.
Comment 1 Mark Hahnenberg 2011-09-06 19:30:29 PDT 
Created attachment 106535 [details]
Patch
Comment 2 Mark Hahnenberg 2011-09-07 10:53:31 PDT 
Created attachment 106600 [details]
Patch
Comment 3 Mark Hahnenberg 2011-09-07 13:24:44 PDT 
Created attachment 106625 [details]
Patch
Comment 4 Oliver Hunt 2011-09-07 15:38:57 PDT 
Comment on attachment 106625 [details]
Patch

r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit)
Comment 5 Mark Hahnenberg 2011-09-07 15:43:35 PDT 
(In reply to comment #4)
> (From update of attachment 106625 [details])
> r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit)

No regressions that I can see.
Comment 6 Geoffrey Garen 2011-09-07 16:47:15 PDT 
Comment on attachment 106625 [details]
Patch

cq+, since mark is not yet a committer.
Comment 7 WebKit Review Bot 2011-09-08 11:41:00 PDT 
Comment on attachment 106625 [details]
Patch

Clearing flags on attachment: 106625

Committed r94774: <http://trac.webkit.org/changeset/94774>
Comment 8 WebKit Review Bot 2011-09-08 11:41:05 PDT 
All reviewed patches have been landed.  Closing bug.