Bug 67691

Summary: Remove getUInt32 from JSCell
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Hahnenberg
Reported 2011-09-06 18:29:52 PDT
getUInt32 is no longer used in JSC. We should remove it.
Attachments
Patch (2.64 KB, patch)
2011-09-06 19:30 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2011-09-07 10:53 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2011-09-07 13:24 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-09-06 19:30:29 PDT
Created attachment 106535 [details] Patch
Mark Hahnenberg
Comment 2 2011-09-07 10:53:31 PDT
Created attachment 106600 [details] Patch
Mark Hahnenberg
Comment 3 2011-09-07 13:24:44 PDT
Created attachment 106625 [details] Patch
Oliver Hunt
Comment 4 2011-09-07 15:38:57 PDT
Comment on attachment 106625 [details] Patch r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit)
Mark Hahnenberg
Comment 5 2011-09-07 15:43:35 PDT
(In reply to comment #4) > (From update of attachment 106625 [details]) > r=me assuming jsc-tests passes in 32-bit (run-javascriptcore-tests --32-bit) No regressions that I can see.
Geoffrey Garen
Comment 6 2011-09-07 16:47:15 PDT
Comment on attachment 106625 [details] Patch cq+, since mark is not yet a committer.
WebKit Review Bot
Comment 7 2011-09-08 11:41:00 PDT
Comment on attachment 106625 [details] Patch Clearing flags on attachment: 106625 Committed r94774: <http://trac.webkit.org/changeset/94774>
WebKit Review Bot
Comment 8 2011-09-08 11:41:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.