Bug 67689

Summary: Remove JSObjectWithGlobalObject
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: dongseong.hwang, ggaren, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Oliver Hunt
Reported 2011-09-06 18:06:05 PDT
Remove JSObjectWithGlobalObject
Attachments
Patch (78.99 KB, patch)
2011-09-06 18:09 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (84.18 KB, patch)
2011-09-06 18:29 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (84.68 KB, patch)
2011-09-07 10:51 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (84.90 KB, patch)
2011-09-07 11:42 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-09-06 18:09:06 PDT
Created attachment 106528 [details] Patch
WebKit Review Bot
Comment 2 2011-09-06 18:11:00 PDT
Attachment 106528 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-09-06 18:18:24 PDT
r=me too, but you're going to need to update the windows project file, .def file, and other project files, I assume.
Oliver Hunt
Comment 4 2011-09-06 18:29:35 PDT
Created attachment 106530 [details] Patch
WebKit Review Bot
Comment 5 2011-09-06 18:36:52 PDT
Attachment 106530 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 6 2011-09-06 21:27:47 PDT
Really, the qt bot is 20 builds behind? is it modeling itself after the mac-ews?
Oliver Hunt
Comment 7 2011-09-07 10:51:45 PDT
Created attachment 106599 [details] Patch
WebKit Review Bot
Comment 8 2011-09-07 10:54:54 PDT
Attachment 106599 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 9 2011-09-07 11:18:48 PDT
Comment on attachment 106599 [details] Patch r=me, assuming it builds
Oliver Hunt
Comment 10 2011-09-07 11:22:22 PDT
(In reply to comment #9) > (From update of attachment 106599 [details]) > r=me, assuming it builds I'm not making significant changes, just pounding this through the EWS bots
Oliver Hunt
Comment 11 2011-09-07 11:42:10 PDT
Created attachment 106611 [details] Patch
WebKit Review Bot
Comment 12 2011-09-07 11:46:34 PDT
Attachment 106611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.h:28: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/RegExpObject.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 13 2011-09-07 12:39:53 PDT
Committed r94701: <http://trac.webkit.org/changeset/94701>
Dongseong Hwang
Comment 15 2011-11-19 01:35:42 PST
There is Source/WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h, yet. That file should be removed, right?
Note You need to log in before you can comment on or make changes to this bug.