Bug 67689

Summary: Remove JSObjectWithGlobalObject
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: dongseong.hwang, ggaren, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Oliver Hunt 2011-09-06 18:06:05 PDT
Remove JSObjectWithGlobalObject
Comment 1 Oliver Hunt 2011-09-06 18:09:06 PDT
Created attachment 106528 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-06 18:11:00 PDT
Attachment 106528 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1

Source/JavaScriptCore/runtime/MathObject.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/RegExpObject.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-09-06 18:18:24 PDT
r=me too, but you're going to need to update the windows project file, .def file, and other project files, I assume.
Comment 4 Oliver Hunt 2011-09-06 18:29:35 PDT
Created attachment 106530 [details]
Patch
Comment 5 WebKit Review Bot 2011-09-06 18:36:52 PDT
Attachment 106530 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1

Source/JavaScriptCore/runtime/MathObject.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/RegExpObject.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Oliver Hunt 2011-09-06 21:27:47 PDT
Really, the qt bot is 20 builds behind?  is it modeling itself after the mac-ews?
Comment 7 Oliver Hunt 2011-09-07 10:51:45 PDT
Created attachment 106599 [details]
Patch
Comment 8 WebKit Review Bot 2011-09-07 10:54:54 PDT
Attachment 106599 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1

Source/JavaScriptCore/runtime/MathObject.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/RegExpObject.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Geoffrey Garen 2011-09-07 11:18:48 PDT
Comment on attachment 106599 [details]
Patch

r=me, assuming it builds
Comment 10 Oliver Hunt 2011-09-07 11:22:22 PDT
(In reply to comment #9)
> (From update of attachment 106599 [details])
> r=me, assuming it builds
I'm not making significant changes, just pounding this through the EWS bots
Comment 11 Oliver Hunt 2011-09-07 11:42:10 PDT
Created attachment 106611 [details]
Patch
Comment 12 WebKit Review Bot 2011-09-07 11:46:34 PDT
Attachment 106611 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstr..." exit_code: 1

Source/JavaScriptCore/runtime/MathObject.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/RegExpObject.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Oliver Hunt 2011-09-07 12:39:53 PDT
Committed r94701: <http://trac.webkit.org/changeset/94701>
Comment 15 Dongseong Hwang 2011-11-19 01:35:42 PST
There is Source/WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h, yet.
That file should be removed, right?