Bug 67688 – fast/forms/suggested-value-crash.html crashes on Windows

• Component: Forms
• Status: RESOLVED FIXED

[Ryosuke Niwa]

The test added by http://trac.webkit.org/changeset/94586 is crashing on Windows bots:

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r94586%20(16068)/fast/forms/suggested-value-crash-log.txt

[Ryosuke Niwa]

It appears that HTMLNames::inputTag isn't initialized properly. m_impl is null. I don't know enough about window.internals to tell what's the right fix for this issue is (might even be a cl.exe / linker bug). I'm going to replace hasTagName check by isInputElement for now and hope for the best.

[Ryosuke Niwa]

Created attachment 106536 [details]
fixes the bug

[Ryosuke Niwa]

Comment on attachment 106536 [details]
fixes the bug

Clearing flags on attachment: 106536

Committed r94633: <http://trac.webkit.org/changeset/94633>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

Thanks for fixing this!

I think the problem is that we weren't using __declspec(dllimport). From MSDN <http://msdn.microsoft.com/en-us/library/hyx1zcd3(v=vs.71).aspx>:

Note that when you export a variable from a DLL with a .def file, you do not need to specify __declspec(dllexport) on the variable. However, in any file that uses the DLL, you must still use __declspec(dllimport) on the declaration of data.

[Ryosuke Niwa]

(In reply to comment #5)
> Thanks for fixing this!
> 
> I think the problem is that we weren't using __declspec(dllimport). From MSDN <http://msdn.microsoft.com/en-us/library/hyx1zcd3(v=vs.71).aspx>:
> 
> Note that when you export a variable from a DLL with a .def file, you do not need to specify __declspec(dllexport) on the variable. However, in any file that uses the DLL, you must still use __declspec(dllimport) on the declaration of data.

I vaguely remember that dll quirks from my Windows app development days. Can we do that for QualifiedNames so that we can use them in internals.cpp?