Bug 67685

Summary: Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, levin, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67106    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Luke Macpherson 2011-09-06 16:44:36 PDT 
Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Comment 1 Luke Macpherson 2011-09-06 16:57:46 PDT 
Created attachment 106519 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-09-06 17:01:24 PDT 
Comment on attachment 106519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106519&action=review

> LayoutTests/fast/multicol/initial-column-values-expected.txt:2
> +ALERT: blah
> +CONSOLE MESSAGE: line 41: TypeError: 'null' is not an object (evaluating 'document.getElementById("parent").style')

Huh?
Comment 3 Luke Macpherson 2011-09-06 17:03:16 PDT 
Good point. Let me take a look...
Comment 4 Luke Macpherson 2011-09-06 17:30:13 PDT 
Created attachment 106523 [details]
Patch
Comment 5 Luke Macpherson 2011-09-06 17:37:17 PDT 
Looks like I had somehow uploaded an in-progress copy. Should be better now.
Comment 6 Eric Seidel (no email) 2011-09-06 18:22:29 PDT 
Comment on attachment 106523 [details]
Patch

OK.
Comment 7 WebKit Review Bot 2011-09-08 11:37:20 PDT 
Comment on attachment 106523 [details]
Patch

Clearing flags on attachment: 106523

Committed r94773: <http://trac.webkit.org/changeset/94773>
Comment 8 WebKit Review Bot 2011-09-08 11:37:24 PDT 
All reviewed patches have been landed.  Closing bug.