Summary: | REGRESSION(r94288) build-webkit doesn't work on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | kkristof, ossy, webkit.review.bot | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 67703 | ||||||
Bug Blocks: | 38054 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2011-09-06 07:58:06 PDT
Created attachment 106554 [details]
proposed fix
Comment on attachment 106554 [details] proposed fix Rejecting attachment 106554 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9607256 Comment on attachment 106554 [details] proposed fix Clearing flags on attachment: 106554 Committed r94655: <http://trac.webkit.org/changeset/94655> All reviewed patches have been landed. Closing bug. We have to roll it out, because it broke Leopard debug bot, and Qt ARM tester: "remove_tree" is not exported by the File::Path module Can't continue after import errors at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36 BEGIN failed--compilation aborted at /home/buildbot/cute1/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/Tools/Scripts/webkitdirs.pm line 36. It was rolled out by http://trac.webkit.org/changeset/94660 We got similar problem on the Symbian bot: "remove_tree" is not exported by the File::Path module Zoltan said that we should use rmtree instead of remove_tree. http://perldoc.perl.org/File/Path.html Fix landed in http://trac.webkit.org/changeset/94663. I hope it will work. :) |