Bug 67643 – [Chromium] Add localizedDescription to WebURLError

• Component: WebKit Misc.
• Status: CLOSED INVALID

[Martin Kosiba]

The Android WebKit port needs access to the localizedDescription WebCore::ResourceError field. We need to pipe that through to WebURLError.

[Steve Block]

> The Android WebKit port
I think you mean the Chromium port on Android

[Martin Kosiba]

(In reply to comment #1)
> > The Android WebKit port
> I think you mean the Chromium port on Android

Yes.

[Martin Kosiba]

Created attachment 106418 [details]
proposed fix

[Peter Beverloo]

+fishd for API review

[Steve Block]

Comment on attachment 106418 [details]
proposed fix

LGTM, but needs API review from fishd

[Darin Fisher (:fishd, Google)]

Comment on attachment 106418 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=106418&action=review

> Source/WebKit/chromium/src/WebURLError.cpp:56
> +        localizedDescription = error.localizedDescription();

what about when we copy a WebURLError to a ResourceError?  don't you want to copy this field then too?
otherwise copying a ResourceError to a WebURLError to a ResourceError will be a lossy operation.

can you say more about why you need this information plumbed through here?

[Martin Kosiba]

We don't need this change anymore.