Bug 67579

Summary: Experiment with removing ability to call a collection (except document.all)
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore JavaScriptAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, heycam, kling, mitz, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-09-04 14:27:36 PDT
public-script-coord would like us to experiment with removing the ability to call collections (with the exception of document.all) and see what breaks.
Attachments
Patch (6.06 KB, patch)
2011-09-04 14:28 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (13.49 KB, patch)
2011-09-14 22:19 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (14.66 KB, patch)
2011-09-15 09:26 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-09-04 14:28:56 PDT
Created attachment 106295 [details] Patch
WebKit Review Bot
Comment 2 2011-09-04 14:34:24 PDT
Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9590451
Sam Weinig
Comment 3 2011-09-04 14:43:43 PDT
There are some tests that would need updating/removal if we do this.
WebKit Review Bot
Comment 4 2011-09-04 15:30:07 PDT
Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9593299
WebKit Review Bot
Comment 5 2011-09-04 15:49:15 PDT
Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9593303
Sam Weinig
Comment 6 2011-09-14 22:19:40 PDT
Created attachment 107458 [details] Patch
Sam Weinig
Comment 7 2011-09-14 22:21:54 PDT
Let's try this experiment. Patch ho!
WebKit Review Bot
Comment 8 2011-09-14 22:58:29 PDT
Comment on attachment 107458 [details] Patch Attachment 107458 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9655860
WebKit Review Bot
Comment 9 2011-09-15 05:29:46 PDT
Comment on attachment 107458 [details] Patch Attachment 107458 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9689030
Sam Weinig
Comment 10 2011-09-15 09:26:47 PDT
Created attachment 107504 [details] Patch
Anders Carlsson
Comment 11 2011-09-15 11:15:17 PDT
Comment on attachment 107504 [details] Patch Please add some more background info to the ChangeLog, looks great otherwise!
Sam Weinig
Comment 12 2011-09-15 11:26:46 PDT
Committed r95203: <http://trac.webkit.org/changeset/95203>
mitz
Comment 13 2011-10-17 22:02:48 PDT
(In reply to comment #12) > Committed r95203: <http://trac.webkit.org/changeset/95203> This broke the iTunes Store. See bug 70303.
Adam Barth
Comment 14 2012-01-30 16:07:51 PST
We've received one complaint about this change: http://code.google.com/p/chromium/issues/detail?id=110985
Note You need to log in before you can comment on or make changes to this bug.