Summary: | Experiment with removing ability to call a collection (except document.all) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | WebCore JavaScript | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, heycam, kling, mitz, oliver, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Sam Weinig
2011-09-04 14:27:36 PDT
Created attachment 106295 [details]
Patch
Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9590451 There are some tests that would need updating/removal if we do this. Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9593299 Comment on attachment 106295 [details] Patch Attachment 106295 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9593303 Created attachment 107458 [details]
Patch
Let's try this experiment. Patch ho! Comment on attachment 107458 [details] Patch Attachment 107458 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9655860 Comment on attachment 107458 [details] Patch Attachment 107458 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9689030 Created attachment 107504 [details]
Patch
Comment on attachment 107504 [details]
Patch
Please add some more background info to the ChangeLog, looks great otherwise!
Committed r95203: <http://trac.webkit.org/changeset/95203> (In reply to comment #12) > Committed r95203: <http://trac.webkit.org/changeset/95203> This broke the iTunes Store. See bug 70303. We've received one complaint about this change: http://code.google.com/p/chromium/issues/detail?id=110985 |