Bug 67576

Summary: [Chromium] Add multiple selection to WebPopupMenuInfo for Android
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, fishd, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2011-09-04 03:27:22 PDT
[Chromium] Add mutliple to WebPopupMenuInfo for Android
Attachments
Patch (3.07 KB, patch)
2011-09-04 03:29 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.14 KB, patch)
2011-09-04 13:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-09-04 03:29:17 PDT
Created attachment 106284 [details] Patch
Adam Barth
Comment 2 2011-09-04 03:30:13 PDT
+fishd for WebKit API review.
Darin Fisher (:fishd, Google)
Comment 3 2011-09-04 08:56:38 PDT
Comment on attachment 106284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106284&action=review R=me, but consider renaming suggestion > Source/WebKit/chromium/public/WebPopupMenuInfo.h:46 > + bool multiple; maybe "multiple" is a little too vague here? maybe call it "allowMultipleSelection" or "selectMultiple"? for example, we prefix "index" with "selected" for selectedIndex.
Adam Barth
Comment 4 2011-09-04 13:23:45 PDT
Created attachment 106293 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-09-04 14:23:29 PDT
Comment on attachment 106293 [details] Patch for landing Clearing flags on attachment: 106293 Committed r94507: <http://trac.webkit.org/changeset/94507>
WebKit Review Bot
Comment 6 2011-09-04 14:23:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.