Bug 67549

Summary: [chromium] Check in 'build' for compiled binaries first
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2011-09-02 19:07:25 PDT
[chromium] Check in 'build' for compiled binaries first
Attachments
Patch (2.01 KB, patch)
2011-09-02 19:08 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (3.45 KB, patch)
2011-09-06 10:43 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-09-02 19:08:27 PDT
Created attachment 106237 [details] Patch
Tony Chang
Comment 2 2011-09-02 19:08:50 PDT
Suggestions on how to test this would be welcome.
Dirk Pranke
Comment 3 2011-09-02 19:27:07 PDT
Comment on attachment 106237 [details] Patch The change looks fine to me so I'm R+'ing it. I'm on the fence as to whether writing tests for this is particularly valuable, but if you did want to, the way I'd do it would be to add some tests to chromium_win_unittest that created a port, overrode the port._filesystem field to a dummy object that implemented exists() for various paths, and then called port.build_path to exercise various branches.
Tony Chang
Comment 4 2011-09-06 10:43:16 PDT
Created attachment 106441 [details] Patch
Tony Chang
Comment 5 2011-09-06 12:06:16 PDT
Test added. Can you take another look?
WebKit Review Bot
Comment 6 2011-09-06 13:31:45 PDT
Comment on attachment 106441 [details] Patch Clearing flags on attachment: 106441 Committed r94592: <http://trac.webkit.org/changeset/94592>
WebKit Review Bot
Comment 7 2011-09-06 13:31:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.