Bug 67526

Summary: Add WKContext API to garbage collect JavaScript objects
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, jchaffraix, sam, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67546    
Bug Blocks:    
Attachments:
Description Flags
Patch darin: review+

Ada Chan
Reported 2011-09-02 14:56:45 PDT
Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in JavaScript in the WebProcess.
Attachments
Patch (4.80 KB, patch)
2011-09-02 15:05 PDT, Ada Chan 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2011-09-02 15:05:35 PDT
Created attachment 106204 [details] Patch
Ada Chan
Comment 2 2011-09-02 15:20:51 PDT
Committed: http://trac.webkit.org/changeset/94454
Julien Chaffraix
Comment 3 2011-09-02 17:35:55 PDT
This patch broke Windows: 5>..\WebProcess\WebProcess.cpp(939) : error C2228: left of '.garbageCollectNow' must have class/struct/union 5> type is ''unknown-type'' 5>..\WebProcess\WebProcess.cpp(939) : error C3861: 'gcController': identifier not found (http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/20560/steps/compile-webkit/logs/stdio) Do you have any plans to fix that soon or should we roll the patch out?
Julien Chaffraix
Comment 4 2011-09-02 20:06:41 PDT
FYI the patch got rolled out just after Michael Saboff fixed the release builds. The patch was rolled back in shortly after.
Note You need to log in before you can comment on or make changes to this bug.