Bug 67482

Summary:

[CMake] Detect the operating system in a more generic way.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

New Bugs

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, leandro, paroga, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Raphael Kubo da Costa (:rakuco) 2011-09-02 06:12:40 PDT

[CMake] Detect the operating system in a more generic way.

Comment 1 Raphael Kubo da Costa (:rakuco) 2011-09-02 06:13:26 PDT

Created attachment 106122 [details]
Patch

Comment 2 Patrick R. Gansterer 2011-09-02 06:28:32 PDT

Comment on attachment 106122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106122&action=review

> Source/CMakeLists.txt:76
> +IF (UNIX)

ok

> Source/CMakeLists.txt:82
> +ELSEIF (WIN32)

WIN32 isn't defined for Windows CE!

Comment 3 Raphael Kubo da Costa (:rakuco) 2011-09-02 06:34:10 PDT

(In reply to comment #2)
> > Source/CMakeLists.txt:82
> > +ELSEIF (WIN32)
> 
> WIN32 isn't defined for Windows CE!

Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)?

Comment 4 Raphael Kubo da Costa (:rakuco) 2011-09-02 06:36:31 PDT

Created attachment 106125 [details]
Patch

Comment 5 Patrick R. Gansterer 2011-09-02 06:37:18 PDT

Comment on attachment 106125 [details]
Patch

LGTM

Comment 6 Patrick R. Gansterer 2011-09-02 07:02:12 PDT

(In reply to comment #3)
> (In reply to comment #2)
> > > Source/CMakeLists.txt:82
> > > +ELSEIF (WIN32)
> > 
> > WIN32 isn't defined for Windows CE!
> 
> Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)?

Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog. If it's ok for you i'd like to keep the windows part as it for now.

Comment 7 Raphael Kubo da Costa (:rakuco) 2011-09-02 07:12:48 PDT

(In reply to comment #6)
> (In reply to comment #3)
> > Sorry, will bake a new patch soon. By the way, is this really an expected behavior from CMake? Is WinCE different enough for it not to be recognized as WIN32 (as it also works for windows 64)?
> 
> Not sure, but since there is no offical WinCE support at the moment, it's hard to say what's correct/wrog.

Do you mean there's no official WinCE support in CMake itself?

> If it's ok for you i'd like to keep the windows part as it for now.

No problem.

Comment 8 Raphael Kubo da Costa (:rakuco) 2011-09-25 13:15:02 PDT

CC'ing reviewers.

Comment 9 WebKit Review Bot 2011-09-26 13:08:05 PDT

Comment on attachment 106125 [details]
Patch

Clearing flags on attachment: 106125

Committed r95986: <http://trac.webkit.org/changeset/95986>

Comment 10 WebKit Review Bot 2011-09-26 13:08:11 PDT

All reviewed patches have been landed.  Closing bug.