Summary: | REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, dglazkov, fishd, gustavo.noronha, gustavo, honten, isherman, jhawkins, tkent, xan.lopez, zelidrag | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-09-01 16:33:07 PDT
http://code.google.com/p/chromium/issues/detail?id=95048 Comment 6 by isherman@chromium.org, Today (2 hours ago) It looks like the problem is that setSuggestedValue() is not updating the renderer. > All these auto-fill tests are super annoying. Someone should make a corresponding WebKit test so that I don't have to debug chromium. I'll debug it tomorrow. Or you could add layout tests along with your fix ;) There aren't a lot of existing layout tests in this area because DRT only recently gained the necessary infrastructure to write such tests. Comment 8 by rniwa@chromium.org, Today (2 hours ago) Indeed. I bet we just need to replace the call to updateFromElement by a call to updateInnerTextValue in HTMLInputElement::setSuggestedValue. http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLInputElement.cpp#L1066 Created attachment 106269 [details]
fixes the bug
Note that the same change has been tried on the try bots and had green runs: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/53193 http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/47289 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/47269 Comment on attachment 106269 [details] fixes the bug Attachment 106269 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9587405 Comment on attachment 106269 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=106269&action=review > Source/WebCore/ChangeLog:8 > + Fixed the bug by updating inner text value in setSuggestedValue. I couldn’t find that change in the patch. (In reply to comment #5) > (From update of attachment 106269 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106269&action=review > > > Source/WebCore/ChangeLog:8 > > + Fixed the bug by updating inner text value in setSuggestedValue. > > I couldn’t find that change in the patch. Oops, I apparently reverted the change temporarily to test my test and forget to un-revert it. Will post a new patch in a few minutes. Created attachment 106278 [details]
Fixed win & gtk builds
Comment on attachment 106278 [details] Fixed win & gtk builds Attachment 106278 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9590321 Comment on attachment 106278 [details]
Fixed win & gtk builds
Looks good.
Can someone who has access to GTK+ environment tell me what the C++ mangled name for WebCore::HTMLInputElement::suggestedValue() const is? (In reply to comment #10) > Can someone who has access to GTK+ environment tell me what the C++ mangled name for WebCore::HTMLInputElement::suggestedValue() const is? It should be _ZNK7WebCore16HTMLInputElement14suggestedValueEv. Committed r94586: <http://trac.webkit.org/changeset/94586> |