Bug 67399

Summary: Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, paulirish, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Description Vsevolod Vlasov 2011-09-01 07:25:09 PDT 
XMLHttpRequest console logging messages should link to network panel when possible.
Comment 1 Vsevolod Vlasov 2011-09-01 08:02:10 PDT 
Created attachment 105965 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-01 09:45:44 PDT 
Comment on attachment 105965 [details]
Patch

Attachment 105965 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9581324
Comment 3 Vsevolod Vlasov 2011-09-01 09:58:08 PDT 
Created attachment 105983 [details]
Patch
Comment 4 Yury Semikhatsky 2011-09-05 23:59:37 PDT 
Comment on attachment 105983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105983&action=review

> Source/WebCore/inspector/front-end/inspector.js:1264
> +        if (typeof(lineNumber) !== "undefined") {

style: no need for brackets around typeof argument
Comment 5 Vsevolod Vlasov 2011-09-21 09:24:34 PDT 
Created attachment 108169 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-21 09:33:29 PDT 
Comment on attachment 108169 [details]
Patch

Attachment 108169 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9765816
Comment 7 WebKit Review Bot 2011-09-21 09:54:57 PDT 
Comment on attachment 108169 [details]
Patch

Attachment 108169 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9764829

New failing tests:
inspector/protocol/console-agent.html
Comment 8 Vsevolod Vlasov 2011-09-21 10:09:13 PDT 
Created attachment 108174 [details]
Patch
Comment 9 WebKit Review Bot 2011-09-21 11:23:02 PDT 
Comment on attachment 108174 [details]
Patch

Attachment 108174 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9764868
Comment 10 Vsevolod Vlasov 2011-09-22 04:54:08 PDT 
Created attachment 108314 [details]
Patch
Comment 11 Pavel Feldman 2011-09-22 05:08:02 PDT 
Comment on attachment 108174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108174&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:502
> +WebInspector.ConsoleMessage.NetworkMessageType = {

This seems ugly. Sorry for dragging you into it. I'd say that we can dupe messages strings for network and keep them both in front-end and back-end for the sake of the better protocol.
Comment 12 Vsevolod Vlasov 2011-09-22 07:26:13 PDT 
Created attachment 108329 [details]
Patch
Comment 13 Vsevolod Vlasov 2011-09-26 13:06:10 PDT 
Committed r95984: <http://trac.webkit.org/changeset/95984>