Bug 67380

Summary: [GTK] Generate gobject bindings for Notification and NotificationCenter
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebKitGTKAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 67490    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-09-01 02:16:36 PDT
[GTK] Generate gobject bindings for Notification and NotificationCenter
Attachments
Patch (1.37 KB, patch)
2011-09-01 02:19 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-09-01 02:19:34 PDT
Created attachment 105928 [details] Patch
Philippe Normand
Comment 2 2011-09-02 03:09:06 PDT
Comment on attachment 105928 [details] Patch LGTM and GTK EWS didn't complain. Thanks!
WebKit Review Bot
Comment 3 2011-09-02 04:09:56 PDT
Comment on attachment 105928 [details] Patch Clearing flags on attachment: 105928 Committed r94404: <http://trac.webkit.org/changeset/94404>
WebKit Review Bot
Comment 4 2011-09-02 04:10:00 PDT
All reviewed patches have been landed. Closing bug.
Xan Lopez
Comment 5 2011-09-02 09:32:51 PDT
This patch is wrong in several ways. - It's not adding the headers to the Makefile, so the end result is broken. - You need to reviewers r+ to add new API. - We don't add new bindings API without a justification of why we would want to do so. - We are already working on this elsewhere, and this has some problems that we need to discuss without going ahead: https://bugs.webkit.org/show_bug.cgi?id=61140 I'm going to rollout for all those reasons.
Philippe Normand
Comment 6 2011-09-02 09:53:29 PDT
Oh, sorry :( It just seemed like an harmless change, I overlooked the API addition implied by this patch.
Note You need to log in before you can comment on or make changes to this bug.