Bug 67372

Summary: [chromium] Move ImageBuffer::platformLayer()
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

noel gordon
Reported 2011-09-01 00:52:25 PDT
Have some toDataURL() related work upcoming and platformLayer() is sitting right in the middle of it :) Hope you don't mind my moving out of the way.
Attachments
Patch (1.87 KB, patch)
2011-09-01 01:00 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2011-09-01 01:00:06 PDT
Created attachment 105919 [details] Patch
noel gordon
Comment 2 2011-09-01 01:27:59 PDT
And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made me think so.
Kenneth Russell
Comment 3 2011-09-01 11:45:46 PDT
Comment on attachment 105919 [details] Patch This looks fine.
Kenneth Russell
Comment 4 2011-09-01 11:46:35 PDT
(In reply to comment #2) > And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at > http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made > me think so. Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base.
WebKit Review Bot
Comment 5 2011-09-01 12:39:24 PDT
Comment on attachment 105919 [details] Patch Clearing flags on attachment: 105919 Committed r94332: <http://trac.webkit.org/changeset/94332>
WebKit Review Bot
Comment 6 2011-09-01 12:39:28 PDT
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 7 2011-09-01 18:57:46 PDT
(In reply to comment #4) > Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base. OK thanks, so long as we know it.
Note You need to log in before you can comment on or make changes to this bug.