Summary: | [chromium] Move ImageBuffer::platformLayer() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||
Component: | New Bugs | Assignee: | noel gordon <noel.gordon> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kbr, senorblanco, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
noel gordon
2011-09-01 00:52:25 PDT
Created attachment 105919 [details]
Patch
And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made me think so. Comment on attachment 105919 [details]
Patch
This looks fine.
(In reply to comment #2) > And curious, does this routine need a #if USE(ACCELERATED_COMPOSITING) guard? A cursory look at > http://trac.webkit.org/changeset/93157/trunk/Source/WebCore/platform/graphics/ImageBuffer.h made > me think so. Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base. Comment on attachment 105919 [details] Patch Clearing flags on attachment: 105919 Committed r94332: <http://trac.webkit.org/changeset/94332> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Not sure -- it's been a while since we compiled without that flag so there might be several compilation errors throughout the code base. OK thanks, so long as we know it. |