Summary: | empty-urls.html seems to have erratic output. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||||||
Component: | Tools / Tests | Assignee: | Nate Chapin <japhet> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | leandro, levin, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
David Levin
2011-08-31 22:35:27 PDT
The failure I'm seeing on the dashboard appears to be based on whether the load event finishes before notifyDone() is called. Will try to stabilize that. Created attachment 105980 [details]
patch
Comment on attachment 105980 [details] patch Clearing flags on attachment: 105980 Committed r94320: <http://trac.webkit.org/changeset/94320> All reviewed patches have been landed. Closing bug. This doesn't appear to have been fixed for two reasons: 1. The expectations file never had this line removed. 2. The test is still flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2Fempty-urls.html (In reply to comment #5) > This doesn't appear to have been fixed for two reasons: > 1. The expectations file never had this line removed. > 2. The test is still flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2Fempty-urls.html I'm stumped on how to resolve this. It's flaky because the order of the frame load callbacks for the main frame (specifically, didFinishLoadForFrame and didHandleOnloadEventsForFrame) is non-deterministic. I'm not seeing a good way to turn those outputs off, nor how to force the ordering to be deterministic. Suggestions welcome. Comment on attachment 105980 [details]
patch
I think you can turn them off by moving the test out of the "loading" directory.
(In reply to comment #7) > (From update of attachment 105980 [details]) > I think you can turn them off by moving the test out of the "loading" .... That did it. Where on earth is that defined/documented? Created attachment 112780 [details]
yet another attempt
(In reply to comment #9) > Created an attachment (id=112780) [details] > yet another attempt You're going to need to resolve conflicts to get a cq+ that will work. Created attachment 112875 [details]
Patch for landing
Comment on attachment 112875 [details] Patch for landing Clearing flags on attachment: 112875 Committed r98732: <http://trac.webkit.org/changeset/98732> All reviewed patches have been landed. Closing bug. |