Bug 67330

Summary: fix bug in flexbox test with offsetWidth/offsetLeft of 0
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Ojan Vafai
Reported 2011-08-31 15:42:42 PDT
fix bug in flexbox test with offsetWidth/offsetLeft of 0
Attachments
Patch (2.20 KB, patch)
2011-08-31 15:43 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2011-08-31 15:51 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-08-31 15:43:20 PDT
Created attachment 105842 [details] Patch
Ojan Vafai
Comment 2 2011-08-31 15:44:01 PDT
Also remove the '<br>'. That wasn't working because we insert a text node. Not worth refactoring to make it work.
Tony Chang
Comment 3 2011-08-31 15:48:57 PDT
Comment on attachment 105842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105842&action=review > LayoutTests/css3/flexbox/resources/flexbox.js:17 > + if (isDefined(node.offsetWidth) && expectedWidth) { I think we can just drop the node.offsetWidth check. This should still work if it's undefined. > LayoutTests/css3/flexbox/resources/flexbox.js:23 > + if (isDefined(node.offsetLeft) && expectedOffset) { ditto
Ojan Vafai
Comment 4 2011-08-31 15:51:41 PDT
Created attachment 105846 [details] Patch
Ojan Vafai
Comment 5 2011-08-31 16:53:36 PDT
Committed r94250: <http://trac.webkit.org/changeset/94250>
Note You need to log in before you can comment on or make changes to this bug.