Bug 67289 – Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.

• Component: New Bugs
• Status: RESOLVED FIXED

Chromium Mac: Tweak rubber banding overhang shadows. Add a drop shadow from the browser's toolbar.

Created attachment 105775 [details]
Patch

[Nico Weber]

Comment on attachment 105775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105775&action=review

LGTM

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> +        shadowRect.setHeight(kShadowSize);

I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
>      // If both rectangles present, draw a radial gradient for the corner.

I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)

> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:783
> > +        shadowRect.setHeight(kShadowSize);
> 
> I guess the reason you have two calls for the toolbar gradient is because the vertical overhang shadow is always full-height while the horizontal overhang shadow might be smaller.

Correct.

> > Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm:791
> >      // If both rectangles present, draw a radial gradient for the corner.
> 
> I assume you checked that it doesn't look weird that this gets drawn on top of the toolbar shadow :-)

When there's a vertical overhang, the implementation degrades to using additive shadows since it's not really possible to have non-additive shadows in the presence of the corner radial gradient. 

So when the radial gradient is shown, it implies there's a vertical overhang and thus we use additive shadows - so it looks consistent with the horizontal overhang shadows which will also be additive in that case.

[WebKit Review Bot]

Comment on attachment 105775 [details]
Patch

Clearing flags on attachment: 105775

Committed r94234: <http://trac.webkit.org/changeset/94234>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.