Bug 67288

Summary: [Chromium] Inconsistent WebKit.gypi after r94106
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Tools / TestsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexander Pavlov (apavlov)
Reported 2011-08-31 06:23:11 PDT
The patch r94106 breaks at least gclient on Windows: "Error: Missing input file src\third_party\WebKit\Source\WebKit\chromium\tests\MockGraphicsContext3D.h" since WebKit.gypi includes a new file 'tests/MockGraphicsContext3D.h' not added by the patch.
Attachments
Patch (1.18 KB, patch)
2011-08-31 09:55 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2011-08-31 09:55:58 PDT
Created attachment 105784 [details] Patch
Nat Duca
Comment 2 2011-08-31 10:20:12 PDT
Committed r94199: <http://trac.webkit.org/changeset/94199>
Eric Seidel (no email)
Comment 3 2011-09-06 15:43:54 PDT
Comment on attachment 105784 [details] Patch Cleared review? from attachment 105784 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.