Bug 67270

Summary: Rename closeColorChooser to cleanupColorChooser
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
fixed changelog none

Keishi Hattori
Reported 2011-08-31 01:18:25 PDT
Since closeColorChooser won't be closing the color chooser on Mac OS X, I am renaming it to cleanupColorChooser. This will cleanup any color chooser listeners and on other platforms other than Macs the color chooser will close.
Attachments
patch (5.87 KB, patch)
2011-08-31 19:19 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
fixed changelog (5.30 KB, patch)
2011-08-31 20:20 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-08-31 01:22:03 PDT
Will be uploading patch when Bug 67267 lands
Keishi Hattori
Comment 2 2011-08-31 19:19:13 PDT
Created attachment 105884 [details] patch
Kent Tamura
Comment 3 2011-08-31 19:30:20 PDT
Comment on attachment 105884 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=105884&action=review > Source/WebCore/ChangeLog:12 > + I need to take care of any color chooser listeners, I am renaming this to cleanup. This will close the color Using the word 'I' in ChangeLog looks strange. > Source/WebCore/ChangeLog:25 > + * page/ChromeClient.h: > + > +2011-08-31 Keishi Hattori <keishi@webkit.org> > + > + Remove closeColorChooser call from FrameLoader::transitionToCommitted > + https://bugs.webkit.org/show_bug.cgi?id=67267 There are two ChangeLog entries.
Keishi Hattori
Comment 4 2011-08-31 20:20:49 PDT
Created attachment 105889 [details] fixed changelog
Kent Tamura
Comment 5 2011-08-31 20:25:38 PDT
Comment on attachment 105889 [details] fixed changelog ok
WebKit Review Bot
Comment 6 2011-08-31 22:32:41 PDT
Comment on attachment 105889 [details] fixed changelog Clearing flags on attachment: 105889 Committed r94270: <http://trac.webkit.org/changeset/94270>
WebKit Review Bot
Comment 7 2011-08-31 22:32:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.