Bug 67256

Summary: [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
Product: WebKit Reporter: Jarred Nicholls <jarred>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gustavo, mrobinson, ojan, pnormand, webkit.review.bot
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67239    
Attachments:
Description Flags
Patch none

Jarred Nicholls
Reported 2011-08-30 20:28:32 PDT
Gtk DRT should translate file:///tmp/LayoutTests paths into a local URL that's derived from the path of the DRT application exec.
Attachments
Patch (11.26 KB, patch)
2011-12-02 17:18 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-08-31 22:55:11 PDT
Which tests are failing because of this issue?
Jarred Nicholls
Comment 2 2011-08-31 23:28:40 PDT
Any tests that run in NRWT which load a local resource from /tmp/LayoutTests. e.g. fast/dom/frame-loading-via-document-write.html fast/loader/local-CSS-from-local.html fast/loader/local-JavaScript-from-local.html fast/loader/local-image-from-local.html http/tests/security/local-user-CSS-from-remote.html see bug #67254 for Qt's implementation. Chromium's implementation and related logic: http://pastie.org/2464106 original bug #64135
Martin Robinson
Comment 3 2011-12-02 17:18:03 PST
Created attachment 117715 [details] Patch
WebKit Review Bot
Comment 4 2011-12-02 17:21:22 PST
Attachment 117715 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/g..." exit_code: 1 Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:91: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 5 2011-12-03 02:13:57 PST
Comment on attachment 117715 [details] Patch This is neat!
WebKit Review Bot
Comment 6 2011-12-03 03:33:21 PST
Comment on attachment 117715 [details] Patch Clearing flags on attachment: 117715 Committed r101922: <http://trac.webkit.org/changeset/101922>
WebKit Review Bot
Comment 7 2011-12-03 03:33:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.