Bug 67193

Summary: Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Vsevolod Vlasov 2011-08-30 03:39:44 PDT 
Chromium crash report: http://code.google.com/p/chromium/issues/detail?id=93469
Comment 1 Vsevolod Vlasov 2011-08-30 04:29:37 PDT 
Created attachment 105613 [details]
Patch
Comment 2 Yury Semikhatsky 2011-08-30 06:41:53 PDT 
Comment on attachment 105613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105613&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> +    if (!loader || !loader->frame())

All this check should be in if (m_resourcesData->resourceType(requestId) == InspectorPageAgent::DocumentResource), shouldn't them?
Comment 3 Vsevolod Vlasov 2011-08-30 07:26:30 PDT 
Created attachment 105624 [details]
Patch
Comment 4 Vsevolod Vlasov 2011-08-30 08:27:55 PDT 
Committed r94078: <http://trac.webkit.org/changeset/94078>