Bug 67181

Summary: REGRESSION(r88115): "Choose File" button doesn't respect font-size property for the <input>
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch for landing none

Attachments
Patch (19.95 KB, patch)
2011-08-29 23:43 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (20.81 KB, patch)
2011-08-29 23:52 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.10 KB, patch)
2011-08-31 19:26 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-08-29 23:43:59 PDT
Created attachment 105587 [details] Patch
WebKit Review Bot
Comment 2 2011-08-29 23:47:04 PDT
Attachment 105587 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:3483 Path does not exist. fast/forms/file/file-appearnace.html LayoutTests/platform/chromium/test_expectations.txt:3483: Path does not exist. fast/forms/file/file-appearnace.html [test/expectations] [2] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 3 2011-08-29 23:52:15 PDT
Created attachment 105590 [details] Patch 2 Add a missing file
Darin Adler
Comment 4 2011-08-30 10:01:32 PDT
Comment on attachment 105590 [details] Patch 2 Is the font-size the only thing we want to inherit? What about other style properties?
Kent Tamura
Comment 5 2011-08-30 16:17:42 PDT
(In reply to comment #4) > (From update of attachment 105590 [details]) > Is the font-size the only thing we want to inherit? What about other style properties? As you see on the second file upload control in file-appearance-expected.png, 'color' property of input[type=file] should be 'inherit.' But I think it's a very old bug, not a regression by r88115. I have no other ideas of other properties.
Kent Tamura
Comment 6 2011-08-31 00:26:08 PDT
(In reply to comment #5) > As you see on the second file upload control in file-appearance-expected.png, 'color' property of input[type=file] should be 'inherit.' But I think it's a very old bug, not a regression by r88115. I'll fix color issue by another patch.
Dimitri Glazkov (Google)
Comment 7 2011-08-31 18:34:28 PDT
Comment on attachment 105590 [details] Patch 2 can the test be made dump-as-text? You can read shadowRoot using window.internals, then read its computed style.
Kent Tamura
Comment 8 2011-08-31 19:26:19 PDT
Created attachment 105886 [details] Patch for landing Convert the test to dumpAsText
WebKit Review Bot
Comment 9 2011-08-31 19:39:08 PDT
Comment on attachment 105886 [details] Patch for landing Clearing flags on attachment: 105886 Committed r94268: <http://trac.webkit.org/changeset/94268>
WebKit Review Bot
Comment 10 2011-08-31 19:39:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.