Bug 67169 – [chromium] DumpRenderTree should be explicit about its dependency on GoogleURL

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Darin Fisher (:fishd, Google)]

[chromium] DumpRenderTree should be explicit about its dependency on GoogleURL

DumpRenderTree uses GoogleURL code directly, and it should be explicit about that
instead of picking up this dependency transitively, which only works for the static
build.

This is needed to support the "component" build of DumpRenderTree, in which the
various Chromium dependencies are built as separate DLLs.

[Darin Fisher (:fishd, Google)]

Created attachment 105548 [details]
v1 patch

[WebKit Review Bot]

Comment on attachment 105548 [details]
v1 patch

Rejecting attachment 105548 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:

Updating working directory
Processing patch 105548 from bug 67169.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9558538

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/94096 with fixed up reviewer line.