Summary: | querySelector/querySelectorAll should use selector checker fast path | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dglazkov, mathias, oliver, sam, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2011-08-29 16:04:01 PDT
Created attachment 105542 [details] patch, missing non-Mac build files The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/. Some individual subtests (using child or descendant selectors) execute twice as fast. Created attachment 105602 [details]
patch
Created attachment 105615 [details]
updated to tot
Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9565414 Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9566377 Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9565415 Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9563470 Created attachment 105626 [details]
build fix
Attachment 105626 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/dom/SelectorQuery.h:54: Missing space inside { }. [whitespace/braces] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 105626 [details] build fix Attachment 105626 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9558602 This is really cool stuff, Antti. Created attachment 105631 [details]
style & win build fix
Comment on attachment 105631 [details] style & win build fix Attachment 105631 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9563499 Comment on attachment 105631 [details]
style & win build fix
Awesome! r=me, but do what Adam says about the windows build file.
|