Bug 67161

Summary: querySelector/querySelectorAll should use selector checker fast path
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mathias, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch, missing non-Mac build files
none
patch
none
updated to tot
webkit.review.bot: commit-queue-
build fix
gyuyoung.kim: commit-queue-
style & win build fix sam: review+, gyuyoung.kim: commit-queue-

Antti Koivisto
Reported 2011-08-29 16:04:01 PDT
Descendant and child selectors can be matches substantially faster using SelectorChecker::fastCheckSelector() path. Currently it is used for style matching only.
Attachments
patch, missing non-Mac build files (29.95 KB, patch)
2011-08-29 16:38 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (34.65 KB, patch)
2011-08-30 02:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
updated to tot (34.84 KB, patch)
2011-08-30 04:45 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
build fix (34.86 KB, patch)
2011-08-30 07:41 PDT, Antti Koivisto 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
style & win build fix (35.39 KB, patch)
2011-08-30 08:15 PDT, Antti Koivisto 		sam: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2011-08-29 16:38:23 PDT
Created attachment 105542 [details] patch, missing non-Mac build files The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/. Some individual subtests (using child or descendant selectors) execute twice as fast.
Antti Koivisto
Comment 2 2011-08-30 02:42:57 PDT
Created attachment 105602 [details] patch
Antti Koivisto
Comment 3 2011-08-30 04:45:59 PDT
Created attachment 105615 [details] updated to tot
WebKit Review Bot
Comment 4 2011-08-30 04:50:16 PDT
Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9565414
Gyuyoung Kim
Comment 5 2011-08-30 04:50:22 PDT
Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9566377
Early Warning System Bot
Comment 6 2011-08-30 04:54:34 PDT
Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9565415
WebKit Review Bot
Comment 7 2011-08-30 06:23:21 PDT
Comment on attachment 105615 [details] updated to tot Attachment 105615 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9563470
Antti Koivisto
Comment 8 2011-08-30 07:41:35 PDT
Created attachment 105626 [details] build fix
WebKit Review Bot
Comment 9 2011-08-30 07:43:34 PDT
Attachment 105626 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/SelectorQuery.h:54: Missing space inside { }. [whitespace/braces] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 10 2011-08-30 07:50:17 PDT
Comment on attachment 105626 [details] build fix Attachment 105626 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9558602
Dimitri Glazkov (Google)
Comment 11 2011-08-30 07:55:21 PDT
This is really cool stuff, Antti.
Antti Koivisto
Comment 12 2011-08-30 08:15:37 PDT
Created attachment 105631 [details] style & win build fix
Gyuyoung Kim
Comment 13 2011-08-30 08:20:18 PDT
Comment on attachment 105631 [details] style & win build fix Attachment 105631 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9563499
Sam Weinig
Comment 14 2011-08-30 10:19:50 PDT
Comment on attachment 105631 [details] style & win build fix Awesome! r=me, but do what Adam says about the windows build file.
Antti Koivisto
Comment 15 2011-08-30 10:43:30 PDT
http://trac.webkit.org/changeset/94089
Note You need to log in before you can comment on or make changes to this bug.