Bug 6716

Summary: cleanup patch for duplicated code in quartz gradient drawing
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: mitz
Priority: P3 Keywords: SVGHitList
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://welcome.linux.org.il/welcome-to-linux-2004.svg
Bug Depends on:    
Bug Blocks: 7199    
Attachments:
Description Flags
reduction
none
cleanup patch
eric: review-
cleanup patch mjs: review+

Eric Seidel (no email)
Reported 2006-01-22 14:10:58 PST
Gradient appears and disappears in SVG http://welcome.linux.org.il/welcome-to-linux-2004.svg We'll need to reduce this to figure out what's going wrong.
Attachments
reduction (512 bytes, image/svg+xml)
2006-01-28 03:54 PST, Alexander Kellett 		no flags
Details
cleanup patch (23.66 KB, patch)
2006-02-06 13:48 PST, Alexander Kellett 		eric: review-
DetailsFormatted DiffDiff
cleanup patch (23.13 KB, patch)
2006-02-09 00:49 PST, Alexander Kellett 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-01-26 16:21:32 PST
High visibility user issue. SVGHitList.
Alexander Kellett
Comment 2 2006-01-28 03:29:01 PST
does not render with a gradient in either opera or firefox, however, this is not serious enough to be a hitlist / p2 item, so removing the keyword and making p3
Alexander Kellett
Comment 3 2006-01-28 03:54:07 PST
Created attachment 6042 [details] reduction
Alexander Kellett
Comment 4 2006-01-28 03:55:05 PST
have a reduction now, making hitlist as this shows a major bug in gradient filled text
Alexander Kellett
Comment 5 2006-02-06 13:48:28 PST
Created attachment 6302 [details] cleanup patch
Eric Seidel (no email)
Comment 6 2006-02-09 00:43:34 PST
Comment on attachment 6302 [details] cleanup patch We talked about this on irc. This can be done cleaner w/o addin a new "BaseClass" class.
Alexander Kellett
Comment 7 2006-02-09 00:49:09 PST
Created attachment 6358 [details] cleanup patch
Maciej Stachowiak
Comment 8 2006-02-09 01:52:41 PST
Comment on attachment 6358 [details] cleanup patch r=me
Adele Peterson
Comment 9 2006-02-11 12:15:05 PST
Maciej committed this.
Note You need to log in before you can comment on or make changes to this bug.