Bug 67141

Summary: Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, darin, dglazkov, eric, morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66241    
Attachments:
Description Flags
cleanup eric: review+, eric: commit-queue-

Ryosuke Niwa
Reported 2011-08-29 11:34:04 PDT
notifyFormStateChanged is duplicated in HTMLInputElement and HTMLTextAreaElement (one is a static local function, and the other one is a member of HTMLInputElement). Also formControlValueMatchesRenderer and setFormControlValueMatchesRenderer are somehow member functions of Node, which is probably a left-over from WML.
Attachments
cleanup (9.84 KB, patch)
2011-08-29 11:40 PDT, Ryosuke Niwa 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-08-29 11:40:44 PDT
Created attachment 105506 [details] cleanup
Ryosuke Niwa
Comment 2 2011-08-29 11:41:16 PDT
I just had to refactor code. The existing code was too disgusting.
Eric Seidel (no email)
Comment 3 2011-08-29 11:51:58 PDT
Comment on attachment 105506 [details] cleanup LGTM.
Eric Seidel (no email)
Comment 4 2011-08-29 12:04:04 PDT
Comment on attachment 105506 [details] cleanup Attachment 105506 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9569063
Ryosuke Niwa
Comment 5 2011-08-29 13:18:51 PDT
Committed r94009: <http://trac.webkit.org/changeset/94009>
Note You need to log in before you can comment on or make changes to this bug.