Assertion failure in RenderLayer::computeRepaintRects when scrolling

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Julien Chaffraix]

r93837 added an ASSERT when calling computeRepaintRects. It looks like it is hit when scrolling, likely in the following code:

RenderLayer::updateLayerPositionsAfterScroll(bool fixed)
{
    (...)


        computeRepaintRects();

We do not check if the layer is visible (in which case we could likely return early as empty layers have no repaint rectangles anyway).

[Julien Chaffraix]

Created attachment 105507 [details]
WIP patch, missing baseline for mac.

[Julien Chaffraix]

Created attachment 105509 [details]
Proposed fix: Bail early if we see a layer with no visible content.

[Dave Hyatt]

Comment on attachment 105509 [details]
Proposed fix: Bail early if we see a layer with no visible content.

View in context: https://bugs.webkit.org/attachment.cgi?id=105509&action=review

r=me

> Source/WebCore/rendering/RenderLayer.cpp:394
> +    // they will be empty. If our visibility change, we are expected to recompute all

Typo. Should be "changes"

[Julien Chaffraix]

Created attachment 105518 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 105518 [details]
Patch for landing

Clearing flags on attachment: 105518

Committed r94016: <http://trac.webkit.org/changeset/94016>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.