Bug 67104

Summary: Update registerProtocolHandler scheme whitelist to match spec
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, koz, mikelawther, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ben Wells 2011-08-28 22:12:14 PDT 
Update registerProtocolHandler scheme whitelist to match spec
Comment 1 Ben Wells 2011-08-28 22:31:08 PDT 
Created attachment 105460 [details]
Patch
Comment 2 Darin Adler 2011-08-29 10:57:09 PDT 
Comment on attachment 105460 [details]
Patch

Can we test this?
Comment 3 Adam Barth 2011-08-29 12:19:33 PDT 
> Can we test this?

Does registerProtocolHandler report some sort of error when you register something off the whitelist?  Maybe we could register something and try to use the registration?  Seems like it ought to be testable.
Comment 4 Ben Wells 2011-08-29 22:00:20 PDT 
Created attachment 105575 [details]
Patch
Comment 5 Ben Wells 2011-08-29 22:01:27 PDT 
Comment on attachment 105575 [details]
Patch

There is already a test which checks that schemes not in the whitelist fail to register. I've added to this test to make sure all schemes in the whitelist can be registered.
Comment 6 WebKit Review Bot 2011-08-30 08:59:53 PDT 
Comment on attachment 105575 [details]
Patch

Clearing flags on attachment: 105575

Committed r94079: <http://trac.webkit.org/changeset/94079>
Comment 7 WebKit Review Bot 2011-08-30 08:59:57 PDT 
All reviewed patches have been landed.  Closing bug.