Bug 67094

Summary: [Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, webkit.review.bot
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
fix v2 none

Balazs Kelemen
Reported 2011-08-28 12:29:25 PDT
A build fix related to C API versioning: http://trac.webkit.org/changeset/93949 I suggest to apply this style of initialization everywhere for consistency and to avoid future build breakages.
Attachments
proposed fix (4.04 KB, patch)
2011-09-06 05:14 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
fix v2 (4.28 KB, patch)
2011-09-07 01:29 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-09-06 05:14:53 PDT
Created attachment 106408 [details] proposed fix
Balazs Kelemen
Comment 2 2011-09-07 01:15:28 PDT
Comment on attachment 106408 [details] proposed fix It's not correct. Since we always build against trunk we should use the current version of the client structures. This way we can notice functional changes that affect us. Another argument is that WebKit::APIClient except the version number and the layout of the structure is matching.
Balazs Kelemen
Comment 3 2011-09-07 01:29:55 PDT
Created attachment 106555 [details] fix v2
Andreas Kling
Comment 4 2011-09-11 17:14:10 PDT
Comment on attachment 106555 [details] fix v2 LGTM.
WebKit Review Bot
Comment 5 2011-09-11 20:20:35 PDT
Comment on attachment 106555 [details] fix v2 Clearing flags on attachment: 106555 Committed r94937: <http://trac.webkit.org/changeset/94937>
WebKit Review Bot
Comment 6 2011-09-11 20:20:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.