Bug 67094

Summary: [Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, webkit.review.bot
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
fix v2 none

Description Balazs Kelemen 2011-08-28 12:29:25 PDT 
A build fix related to C API versioning: http://trac.webkit.org/changeset/93949
I suggest to apply this style of initialization everywhere for consistency and to avoid future build breakages.
Comment 1 Balazs Kelemen 2011-09-06 05:14:53 PDT 
Created attachment 106408 [details]
proposed fix
Comment 2 Balazs Kelemen 2011-09-07 01:15:28 PDT 
Comment on attachment 106408 [details]
proposed fix

It's not correct. Since we always build against trunk we should use the current version of the client structures. This way we can notice functional changes that affect us. Another argument is that WebKit::APIClient except the version number and the layout of the structure is matching.
Comment 3 Balazs Kelemen 2011-09-07 01:29:55 PDT 
Created attachment 106555 [details]
fix v2
Comment 4 Andreas Kling 2011-09-11 17:14:10 PDT 
Comment on attachment 106555 [details]
fix v2

LGTM.
Comment 5 WebKit Review Bot 2011-09-11 20:20:35 PDT 
Comment on attachment 106555 [details]
fix v2

Clearing flags on attachment: 106555

Committed r94937: <http://trac.webkit.org/changeset/94937>
Comment 6 WebKit Review Bot 2011-09-11 20:20:39 PDT 
All reviewed patches have been landed.  Closing bug.