Summary: | Implement NPN_ScheduleTimer/NPN_UnscheduleTimer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2011-08-26 13:36:54 PDT
Created attachment 105402 [details]
Patch
Comment on attachment 105402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105402&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:338 > +void NetscapePlugin::Timer::start(bool throttle) > +{ Please remove the parameter. > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:256 > + NetscapePlugin* m_netscapePlugin; Please put a comment here explaining the lifetime of this pointer. Committed r93912: <http://trac.webkit.org/changeset/93912> |