Bug 67039

Summary: Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-08-26 09:38:02 PDT
Fix to follow.
Attachments
Patch (3.33 KB, patch)
2011-08-26 09:50 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-26 09:46:08 PDT
Total problems found: 1. Popup renamed to Popover in half of the places, as a result, this._hidePopoverTimer is not getting removed. [regression] 2. contentElement.addEventListener("mousemove", this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true); was entirely forgotten and caused this [regression]. 3. Strange delete this._popupInstanceMarker in the code We will need to hold off commits like this in the future since they compromise the "polish" activity we are performing.
Pavel Feldman
Comment 2 2011-08-26 09:50:45 PDT
Created attachment 105366 [details] Patch
Yury Semikhatsky
Comment 3 2011-08-26 09:55:24 PDT
Comment on attachment 105366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105366&action=review > Source/WebCore/inspector/front-end/Popover.js:33 > + * @param {WebInspector.Popover} popoverHelper Popover -> PopoverHelper=?
Pavel Feldman
Comment 4 2011-08-26 09:57:48 PDT
Committed r93882: <http://trac.webkit.org/changeset/93882>
Note You need to log in before you can comment on or make changes to this bug.