Bug 67030

Summary: Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Pavel Podivilov
Reported 2011-08-26 04:07:08 PDT
Web Inspector: Debugger.setBreakpointByUrl should return error when setting breakpoint on the same location twice. Currently it just returns empty breakpointId without any error message which is confusing. Original request: http://code.google.com/p/chromium/issues/detail?id=87879.
Attachments
Patch (12.50 KB, patch)
2011-08-26 04:11 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (12.40 KB, patch)
2011-08-26 04:50 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-08-26 04:11:42 PDT
Created attachment 105344 [details] Patch
Pavel Podivilov
Comment 2 2011-08-26 04:12:57 PDT
* Add error message. * Add test that sets breakpoint in the same location twice. * Rename debugger-pause-on-breakpoint -> set-breakpoint.
WebKit Review Bot
Comment 3 2011-08-26 04:35:14 PDT
Comment on attachment 105344 [details] Patch Attachment 105344 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9541010 New failing tests: inspector/debugger/set-breakpoint.html
Pavel Podivilov
Comment 4 2011-08-26 04:50:04 PDT
Created attachment 105346 [details] Patch
Pavel Podivilov
Comment 5 2011-08-29 01:54:04 PDT
Committed r93962: <http://trac.webkit.org/changeset/93962>
Note You need to log in before you can comment on or make changes to this bug.