Bug 67019

Summary: Add layout test for locale-based font selection
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jshin, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
expected result
none
Patch
none
rebase none

Matt Falkenhagen
Reported 2011-08-25 23:14:26 PDT
Add layout test for -webkit-locale based font selection (bug 10874). I would assign this to myself but it seems I can't edit that field.
Attachments
Patch (1.75 KB, patch)
2011-08-25 23:40 PDT, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Patch (7.00 KB, patch)
2011-11-06 23:50 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
expected result (2.81 KB, image/png)
2011-11-06 23:53 PST, Matt Falkenhagen 		no flags
Details
Patch (7.54 KB, patch)
2011-11-07 02:47 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
rebase (7.61 KB, patch)
2011-11-07 19:18 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2011-08-25 23:40:03 PDT
Created attachment 105319 [details] Patch
Matt Falkenhagen
Comment 2 2011-08-25 23:41:13 PDT
There are no expectations yet since default per-script fonts are not set for any platform (except Chrome OS). I thought we could add the test now and add expectations as the defaults come in.
Darin Adler
Comment 3 2011-08-26 10:06:19 PDT
Comment on attachment 105319 [details] Patch New regression tests need to come with expected results files. It’s not correct to add a test without the results.
Matt Falkenhagen
Comment 4 2011-11-06 23:50:38 PST
Created attachment 113829 [details] Patch
Matt Falkenhagen
Comment 5 2011-11-06 23:53:16 PST
Created attachment 113830 [details] expected result Here is the expected result generated on my machine (I didn't include in the patch as my machine settings may differ from the buildbots).
Kent Tamura
Comment 6 2011-11-07 00:12:17 PST
Comment on attachment 113829 [details] Patch > I didn't include in the patch as my machine settings may differ from the buildbots Ok, it sounds reasonable.
WebKit Review Bot
Comment 7 2011-11-07 01:17:02 PST
Comment on attachment 113829 [details] Patch Rejecting attachment 113829 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Tests/platform/efl/Skipped patching file LayoutTests/platform/gtk/Skipped Hunk #1 succeeded at 456 with fuzz 2 (offset 12 lines). patching file LayoutTests/platform/mac/Skipped patching file LayoutTests/platform/qt/Skipped patching file LayoutTests/platform/win/Skipped patching file LayoutTests/platform/wincairo/Skipped patching file LayoutTests/platform/wk2/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10332591
Matt Falkenhagen
Comment 8 2011-11-07 02:47:38 PST
Created attachment 113838 [details] Patch
WebKit Review Bot
Comment 9 2011-11-07 03:02:51 PST
Comment on attachment 113838 [details] Patch Rejecting attachment 113838 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10337730
WebKit Review Bot
Comment 10 2011-11-07 03:09:23 PST
Comment on attachment 113838 [details] Patch Rejecting attachment 113838 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ayoutTests/platform/efl/Skipped patching file LayoutTests/platform/gtk-wk2/Skipped patching file LayoutTests/platform/gtk/Skipped patching file LayoutTests/platform/mac/Skipped patching file LayoutTests/platform/qt/Skipped patching file LayoutTests/platform/win/Skipped patching file LayoutTests/platform/wincairo/Skipped patching file LayoutTests/platform/wk2/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10333646
Matt Falkenhagen
Comment 11 2011-11-07 03:11:09 PST
Looks like it's conflicting with recent change: http://trac.webkit.org/changeset/99402 I'll rebase and try again tomorrow.
Matt Falkenhagen
Comment 12 2011-11-07 19:18:07 PST
Created attachment 113978 [details] rebase
WebKit Review Bot
Comment 13 2011-11-07 20:31:26 PST
Comment on attachment 113978 [details] rebase Clearing flags on attachment: 113978 Committed r99517: <http://trac.webkit.org/changeset/99517>
WebKit Review Bot
Comment 14 2011-11-07 20:31:32 PST
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 15 2011-11-09 18:27:48 PST
Baseline files were added by http://trac.webkit.org/changeset/99797
Note You need to log in before you can comment on or make changes to this bug.