Bug 67010

Summary: Update topCallFrame when calling host functions in the JIT
Product: WebKit Reporter: Juan C. Montemayor <j.mont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ggaren, j.mont, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66994    
Description Flags
Proposed patch
sunspider test results showing no speed regression
updated patch
patch with changes j.mont: review-, j.mont: commit-queue-

Description Juan C. Montemayor 2011-08-25 18:48:49 PDT
The topCallFrame is not being updated when a host function is called by the JIT. This causes problems when trying to create a stack trace.
Comment 1 Juan C. Montemayor 2011-08-25 22:08:57 PDT
Created attachment 105308 [details]
Proposed patch
Comment 2 Juan C. Montemayor 2011-08-25 22:13:14 PDT
Created attachment 105309 [details]
sunspider test results showing no speed regression
Comment 3 Oliver Hunt 2011-08-26 09:59:43 PDT
Comment on attachment 105308 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105308&action=review

> Source/JavaScriptCore/jit/JITOpcodes.cpp:143
> +    // Fixme: Should TopCallFrame also be uploaded at this location?

Comment 4 Juan C. Montemayor 2011-08-26 10:17:36 PDT
Created attachment 105370 [details]
updated patch
Comment 5 WebKit Review Bot 2011-08-26 14:46:13 PDT
Comment on attachment 105370 [details]
updated patch

Clearing flags on attachment: 105370

Committed r93915: <http://trac.webkit.org/changeset/93915>
Comment 6 WebKit Review Bot 2011-08-26 14:46:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Juan C. Montemayor 2011-08-26 15:49:16 PDT
Created attachment 105416 [details]
patch with changes