Bug 66992

Summary: garden-o-matic summary view should provide information on builders still in flight.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66960    
Attachments:
Description Flags
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-08-25 15:46:34 PDT
garden-o-matic summary view should provide information on builders still in flight.
Attachments
Patch (9.83 KB, patch)
2011-08-25 15:47 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-08-25 15:47:55 PDT
Created attachment 105267 [details] Patch
Adam Barth
Comment 2 2011-08-25 15:59:38 PDT
Comment on attachment 105267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review Very nice. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97 > + var failsFromRevision = failureAnalysis.newestPassingRevision + 1; I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something). We don't actually know that the test fails in this revision. Sorry to be so nit-picky about these revision range things. We weren't careful about this sort of thing in webkitpy and we paid for it severely later.
Dimitri Glazkov (Google)
Comment 3 2011-08-25 16:03:03 PDT
Committed r93830: <http://trac.webkit.org/changeset/93830>
Dimitri Glazkov (Google)
Comment 4 2011-08-25 16:13:19 PDT
Comment on attachment 105267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105267&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:97 >> + var failsFromRevision = failureAnalysis.newestPassingRevision + 1; > > I'd put the word "implied" into the name of this variable (e.g., impliedFirstFailingRevision or something). We don't actually know that the test fails in this revision. > > Sorry to be so nit-picky about these revision range things. We weren't careful about this sort of thing in webkitpy and we paid for it severely later. Sounds good! Done.
Note You need to log in before you can comment on or make changes to this bug.