Bug 66980

Summary: Remove use of magic number -1 in WebCore/editing/visible_units.cpp
Product: WebKit Reporter: Van Lam <vanlam>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: rniwa, vanlam, webkit.review.bot, xji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Van Lam
Reported 2011-08-25 14:28:22 PDT
Currently two functions greatestOffsetUnder and smallestOffsetAbove return -1 to indicate that the correct word boundary to move to is not found. Should be using a constant to make this more clear.
Attachments
Patch (2.83 KB, patch)
2011-08-25 14:31 PDT, Van Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Van Lam
Comment 1 2011-08-25 14:31:55 PDT
Created attachment 105243 [details] Patch
WebKit Review Bot
Comment 2 2011-08-25 16:19:39 PDT
Comment on attachment 105243 [details] Patch Clearing flags on attachment: 105243 Committed r93834: <http://trac.webkit.org/changeset/93834>
WebKit Review Bot
Comment 3 2011-08-25 16:19:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.