Bug 66973

Summary:

WebViewImpl::selectionRange should return range in the right order.

Product:

WebKit

Reporter:

Varun Jain <varunjain>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd, husky, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

96508

Attachments:

Description	Flags
Patch	none
Patch	none

Description Varun Jain 2011-08-25 13:14:28 PDT

WebViewImpl::selectionRange should return range in the right order.

Comment 1 Varun Jain 2011-08-25 13:15:20 PDT

Created attachment 105234 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2011-08-26 10:03:56 PDT

Comment on attachment 105234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105234&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1566
> +        WebPoint tmp = start;

nit: use std::swap here?

Comment 3 Varun Jain 2011-08-26 10:14:41 PDT

Created attachment 105369 [details]
Patch

Comment 4 WebKit Review Bot 2011-08-26 11:07:52 PDT

Comment on attachment 105369 [details]
Patch

Clearing flags on attachment: 105369

Committed r93893: <http://trac.webkit.org/changeset/93893>

Comment 5 WebKit Review Bot 2011-08-26 11:07:56 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Iain Merrick 2012-09-12 07:00:22 PDT

Hi Varun, I just discovered that this has a bad interaction on Android with my recent change to WebFrameImpl::selectRange. I've filed a new bug to try to resolve the difference: https://bugs.webkit.org/show_bug.cgi?id=96508