Bug 66959

Summary: Remove skiaContext methods from CCLayerTreeHost,CCLayerTreeHostImpl, and CCLayerTreeHostImpl*Proxy
Product: WebKit Reporter: Nat Duca <nduca>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, nduca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 66807    
Bug Blocks:    
Attachments:
Description Flags
The hack none

Nat Duca
Reported 2011-08-25 10:45:03 PDT
The CCLayerTreeHost family of classes have a hack in them that allows main-thread code to get to the skiaContext in order to keep accelerated painting working. This is a violation of layering --- we do not want anything on the ContentLayer side to ever have access to LayerRenderer, GraphicsContext, or GrContext state.
Attachments
The hack (8.93 KB, patch)
2011-08-25 10:45 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2011-08-25 10:45:40 PDT
Created attachment 105216 [details] The hack
Nat Duca
Comment 2 2011-11-02 13:02:58 PDT
@alokp fixed this
Note You need to log in before you can comment on or make changes to this bug.